Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added SEAL library and FHE mode #41

Open
wants to merge 27 commits into
base: master
Choose a base branch
from
Open

Added SEAL library and FHE mode #41

wants to merge 27 commits into from

Conversation

Northrim
Copy link
Collaborator

No description provided.

@Northrim Northrim requested review from alex-ozdemir and edwjchen and removed request for alex-ozdemir January 10, 2022 21:29
alex-ozdemir
alex-ozdemir requested changes Jan 10, 2022
View reviewed changes
Copy link
Contributor

@alex-ozdemir alex-ozdemir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far, William. I have a few suggestions within.

.gitmodules Outdated Show resolved Hide resolved
src/front/zokrates/mod.rs Outdated Show resolved Hide resolved
examples/circ.rs Outdated Show resolved Hide resolved
alex-ozdemir
alex-ozdemir reviewed Mar 25, 2022
View reviewed changes
Copy link
Contributor

@alex-ozdemir alex-ozdemir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few questions...

.vscode/settings.json Show resolved Hide resolved
third_party/SEAL_templates/cpp_template.txt Outdated Show resolved Hide resolved
src/target/fhe/utils.rs Outdated Show resolved Hide resolved
scripts/fhe_tests/tests/fhe_and_zok_bytecode.txt Outdated Show resolved Hide resolved
edwjchen
edwjchen requested changes Mar 31, 2022
View reviewed changes
driver.py Outdated Show resolved Hide resolved
scripts/build_fhe_c_test.zsh Outdated Show resolved Hide resolved
scripts/build_fhe_zokrates_test.zsh Outdated Show resolved Hide resolved
scripts/seal_tests/c_test_seal.py Outdated Show resolved Hide resolved
scripts/seal_tests/c_test_seal.py Outdated Show resolved Hide resolved
scripts/seal_tests/zokrates_test_seal.py Outdated Show resolved Hide resolved
src/front/c/mod.rs Outdated Show resolved Hide resolved
src/target/fhe/trans.rs Show resolved Hide resolved
src/target/fhe/trans.rs Show resolved Hide resolved
src/target/fhe/trans.rs Show resolved Hide resolved
edwjchen
edwjchen reviewed Apr 26, 2022
View reviewed changes
Copy link
Collaborator

@edwjchen edwjchen left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few small comments!

@alex-ozdemir when you have a minute, could you take a look at the Map IR lowering?

scripts/build_fhe_zokrates_test.zsh Outdated Show resolved Hide resolved
.vscode/settings.json Show resolved Hide resolved
examples/C/fhe/unit_tests/arithmetic_tests/2pc_add.c Outdated Show resolved Hide resolved
scripts/seal_tests/custom_tests/batch_add_bytecode.txt Outdated Show resolved Hide resolved
scripts/seal_tests/util.py Outdated Show resolved Hide resolved
src/target/fhe/trans.rs Outdated Show resolved Hide resolved
src/target/fhe/utils.rs Show resolved Hide resolved
alex-ozdemir
alex-ozdemir approved these changes Apr 27, 2022
View reviewed changes
Copy link
Contributor

@alex-ozdemir alex-ozdemir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a nit and two questions.

src/target/fhe/trans.rs Outdated Show resolved Hide resolved
src/target/fhe/trans.rs Show resolved Hide resolved
@edwjchen edwjchen self-requested a review April 27, 2022 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edwjchen edwjchen edwjchen approved these changes

@alex-ozdemir alex-ozdemir alex-ozdemir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Northrim @alex-ozdemir @edwjchen @seoyunsoo